Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108434/#review25636
-----------------------------------------------------------


instead of maintoolbar (which could be 128px on even a netbook) maybe relate it to the font height? (what seems to be the idea behind 22px)

- Thomas Lübking


On Jan. 16, 2013, 1:34 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108434/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 1:34 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> It took me hours (really, it's like. System Settings adds a KCModuleProxy which calls KCModuleLoader to load a KCModule which is in some different directory which uses KPageDialog (where I looked at first …) which uses KPageWidget which is a private class inside which then uses KPageView bla.. :D)
> 
> Finally got it and made it use the MainToolbar size which also defaults to 22px, so you won't notice any difference, but users of MacBook Pro Retina and similar devices will appreciate. Also makes it unified a bit because it is always the toolbar icon size.
> 
> 
> Diffs
> -----
> 
>   kdeui/paged/kpageview.cpp 8863934 
> 
> Diff: http://git.reviewboard.kde.org/r/108434/diff/
> 
> 
> Testing
> -------
> 
> Yup, see screenshots.
> 
> Only minor problem is that it doesn't react to when the icon size changes (like buttons and other elements do).
> 
> 
> File Attachments
> ----------------
> 
> KPageDialog icon adapted
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconding.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130116/9e5a61d1/attachment.htm>