Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

Kai Uwe Broulik kde at
Wed Jan 16 01:34:43 GMT 2013

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


It took me hours (really, it's like. System Settings adds a KCModuleProxy which calls KCModuleLoader to load a KCModule which is in some different directory which uses KPageDialog (where I looked at first …) which uses KPageWidget which is a private class inside which then uses KPageView bla.. :D)

Finally got it and made it use the MainToolbar size which also defaults to 22px, so you won't notice any difference, but users of MacBook Pro Retina and similar devices will appreciate. Also makes it unified a bit because it is always the toolbar icon size.


  kdeui/paged/kpageview.cpp 8863934 



Yup, see screenshots.

Only minor problem is that it doesn't react to when the icon size changes (like buttons and other elements do).

File Attachments

KPageDialog icon adapted


Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list