Any chance to fix Bug 312320 in KDE 4.10?
mpyne at kde.org
Thu Jan 3 05:02:05 GMT 2013
On Tuesday, January 01, 2013 11:32:38 Peter Klotz wrote:
> Recently I stumbled over Bug #312320
> (https://bugs.kde.org/show_bug.cgi?id=312320) and created a patch that
> according to my tests fixes the problem.
> Is there a chance that this one-line fix can be incorporated into KDE 4.10?
> Since it is a data corruption issue I would really appreciate having a
> fixed version very soon.
I've taken a look at the bug and though I still do not understand why exactly
the kio_sftp code does not properly subtract out the extra buffer length in
this case, I can confirm the bug.
Your fix is correct in that it properly implements the intent of the listed
code comment, so it should be safe to go in. At this point I'm not sure if
it's the actual "fix" or just a happy accident but I'm too tired to
troubleshoot farther tonight. If no one else gets a chance to look I can
commit and backport tomorrow night (~19 hours from now unfortunately).
- Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: This is a digitally signed message part.
More information about the kde-core-devel