Review Request 109084: [KMenuEdit] fix potential bugs

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109084/#review28311
-----------------------------------------------------------

Ship it!


Commited, please next time, if you are fixing two issues create two requests, more over when one of the issues is a bug in stable and the other one is master only

- Albert Astals Cid


On Feb. 28, 2013, 11:15 p.m., Julien Borderie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109084/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2013, 11:15 p.m.)
> 
> 
> Review request for kde-workspace, Albert Astals Cid and Ömer Fadıl Usta.
> 
> 
> Description
> -------
> 
> This patch fixes a potential null pointer bug (conditional cases are not all handled), and prevents the use of an uninitialized variable (having the same name than argument one).
> (Thanks to Ömer Fad?l Usta)
> 
> 
> Diffs
> -----
> 
>   kmenuedit/treeview.cpp 9d94ee5 
> 
> Diff: http://git.reviewboard.kde.org/r/109084/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Julien Borderie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130228/cfede536/attachment.htm>