Review Request 109133: Allow async KAuth Action with helper (and disallow async without helper)

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109133/#review28101
-----------------------------------------------------------

Ship it!


Looks straightforward.

- Kevin Ottens


On Feb. 25, 2013, 11:25 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109133/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 11:25 p.m.)
> 
> 
> Review request for kdelibs, Aaron J. Seigo, Dario Freddi, David Faure, and Kevin Ottens.
> 
> 
> Description
> -------
> 
> It is async action without helper, instead of with helper, that doesn't make much sense.
> 
> http://lists.kde.org/?l=kde-devel&m=135274807824550&w=2
> 
> 
> This addresses bug 310149.
>     http://bugs.kde.org/show_bug.cgi?id=310149
> 
> 
> Diffs
> -----
> 
>   kdecore/auth/kauthaction.cpp 181547f 
> 
> Diff: http://git.reviewboard.kde.org/r/109133/diff/
> 
> 
> Testing
> -------
> 
> Following pykde4 code doesn't report error and the action is executed successfully (with a valid action_id, helper_id and arguments).
> 
>         action = KAuth.Action(action_id)
>         action.setHelperID(helper_id)
>         action.setArguments(args)
>         if hasattr(callback, "__call__"):
>             # the new-style signal connecting somehow doesn't work here..
>             QObject.connect(action.watcher(),
>                             SIGNAL("actionPerformed(const
> KAuth::ActionReply&)"),
>                             lambda reply: callback(reply.succeeded()))
>         action.setExecutesAsync(True)
>         reply = action.execute()
>         if reply.failed():
>             return False
>         return True
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130226/aae48414/attachment.htm>