<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109133/">http://git.reviewboard.kde.org/r/109133/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks straightforward.</pre>
 <br />









<p>- Kevin</p>


<br />
<p>On February 25th, 2013, 11:25 p.m. UTC, Yichao Yu wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for kdelibs, Aaron J. Seigo, Dario Freddi, David Faure, and Kevin Ottens.</div>
<div>By Yichao Yu.</div>


<p style="color: grey;"><i>Updated Feb. 25, 2013, 11:25 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is async action without helper, instead of with helper, that doesn't make much sense.

http://lists.kde.org/?l=kde-devel&m=135274807824550&w=2
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Following pykde4 code doesn't report error and the action is executed successfully (with a valid action_id, helper_id and arguments).

        action = KAuth.Action(action_id)
        action.setHelperID(helper_id)
        action.setArguments(args)
        if hasattr(callback, "__call__"):
            # the new-style signal connecting somehow doesn't work here..
            QObject.connect(action.watcher(),
                            SIGNAL("actionPerformed(const
KAuth::ActionReply&)"),
                            lambda reply: callback(reply.succeeded()))
        action.setExecutesAsync(True)
        reply = action.execute()
        if reply.failed():
            return False
        return True
</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=310149">310149</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdecore/auth/kauthaction.cpp <span style="color: grey">(181547f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109133/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>