Review Request 108860: Plasma QML Components: trigger appearAnimation in InlineDialog properly

Sebastian Gottfried sebastiangottfried at web.de
Fri Feb 8 16:01:58 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108860/
-----------------------------------------------------------

Review request for KDE Runtime and Marco Martin.


Description
-------

Use `appearAnimation.restart()` instead of `appearAnimation.running = true` to trigger the open/close animation. In the old version it is impossible to open or close the dialog while it is still appearing or disappearing since the old animation simply continues to run.


Diffs
-----

  plasma/declarativeimports/plasmacomponents/qml/private/InlineDialog.qml 2b7b832 

Diff: http://git.reviewboard.kde.org/r/108860/diff/


Testing
-------

Tested within KTouch. Works as expected.


Thanks,

Sebastian Gottfried

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130208/f3ff73e4/attachment.htm>


More information about the kde-core-devel mailing list