Review Request 108860: Plasma QML Components: trigger appearAnimation in InlineDialog properly

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108860/#review26975
-----------------------------------------------------------


This review has been submitted with commit 9fb41fda6c47ba4da7f073e29ea3c3fa25f3be44 by Sebastian Gottfried to branch KDE/4.10.

- Commit Hook


On Feb. 8, 2013, 4:01 p.m., Sebastian Gottfried wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108860/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2013, 4:01 p.m.)
> 
> 
> Review request for KDE Runtime and Marco Martin.
> 
> 
> Description
> -------
> 
> Use `appearAnimation.restart()` instead of `appearAnimation.running = true` to trigger the open/close animation. In the old version it is impossible to open or close the dialog while it is still appearing or disappearing since the old animation simply continues to run.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/private/InlineDialog.qml 2b7b832 
> 
> Diff: http://git.reviewboard.kde.org/r/108860/diff/
> 
> 
> Testing
> -------
> 
> Tested within KTouch. Works as expected.
> 
> 
> Thanks,
> 
> Sebastian Gottfried
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130208/3386a7fd/attachment.htm>