Review Request 108057: Add some new User Agent files for spoofing browser identities in konqueror, rekonq

[Frank Reininghaus]

> On Jan. 7, 2013, 12:33 p.m., Frank Reininghaus wrote:
> > Please run git pull --rebase before pushing any non-merge commits to prevent polluting the logs with commits like
> > 
> > http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=94b3817429b470eed5687922661832b260bcc06c
> > 
> > Thanks.
> 
> Albert Astals Cid wrote:
>     Has this been commited? It has Ship it! but still shows as open in reviewboard.
> 
> Guillaume de Bure wrote:
>     Ship it was given for diff r1, and I did commit it.
>     I did not commit yet the diff r3, for various reasons (laptop died, unsure about comitting during 4.10 RC stage...). If the quality seems OK pollution wise (cf Frank's remark), I can commit it.

My comment hat nothing to do with the quality of the patch. I was just asking for keeping the logs clean by not adding a superfluous merge on top of a single commit.

If you have the commit in your master branch, just run "git pull --rebase" before you push it, and I'm happy :-)


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108057/#review24898
-----------------------------------------------------------


On Jan. 6, 2013, 10:44 p.m., Guillaume de Bure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108057/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 10:44 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> I find that the current list of Browser identities that you can use in konqueror or rekonq is so very obsolete... I used information from http://www.useragentstring.com/pages/Browserlist/ and wrote some additional .desktop files, specifically:
> * Chrome 22, 23, 24
> * Firefox 15, 16
> * IE 8, 9
> * Opera 11, 12
> * Safari 5, 6
> 
> I purposely did not update the CMakeLists.txt yet, waiting for some initial feedback first. I also intend to remove some other entries from the current file list, unsure whether that should come in a separate review request
> 
> 
> Diffs
> -----
> 
>   konqueror/settings/kio/uasproviders/CMakeLists.txt 6c49f42773bb20404ae94e92d8d60c49506505f5 
>   konqueror/settings/kio/uasproviders/android10.desktop 07b393b631363ae8e4a12200508f331bd1fc20a5 
>   konqueror/settings/kio/uasproviders/android235.desktop PRE-CREATION 
>   konqueror/settings/kio/uasproviders/android403.desktop PRE-CREATION 
>   konqueror/settings/kio/uasproviders/chrome10onwinnt51.desktop e9f777f87872c975df69ae424f23594162f5f3e5 
>   konqueror/settings/kio/uasproviders/chrome23oncurrent.desktop PRE-CREATION 
>   konqueror/settings/kio/uasproviders/chrome24oncurrent.desktop PRE-CREATION 
>   konqueror/settings/kio/uasproviders/chrome50oncurrent.desktop 401b5df32cd61f705369e719bb7f5e1376a0af9f 
>   konqueror/settings/kio/uasproviders/firefox15oncurrent.desktop PRE-CREATION 
>   konqueror/settings/kio/uasproviders/firefox16oncurrent.desktop PRE-CREATION 
>   konqueror/settings/kio/uasproviders/firefox20oncurrent.desktop 1e7c477b7805be443e3513aaaf98df28d763ce46 
>   konqueror/settings/kio/uasproviders/firefox30oncurrent.desktop cc6c68f940157966a6a31dad5d65db1503a47f37 
>   konqueror/settings/kio/uasproviders/firefox36oncurrent.desktop 3567a094ceb0d055f00977092431abddc5e4b9d0 
>   konqueror/settings/kio/uasproviders/ie401onwinnt4.desktop 9f8a8115f10a6293fc832141b4fd6014285530f4 
>   konqueror/settings/kio/uasproviders/ie50onppc.desktop a3a833bc4040a4d17b11733b4d28ad79b8913319 
>   konqueror/settings/kio/uasproviders/ie55onwinnt5.desktop 569241ac08d80adce7266c177011527916cf2b98 
>   konqueror/settings/kio/uasproviders/ie60oncurrent.desktop 05ea3f11b49ff67a13e8c17b97416f84e122f552 
>   konqueror/settings/kio/uasproviders/ie80onwinnt60.desktop PRE-CREATION 
>   konqueror/settings/kio/uasproviders/ie90onwinnt71.desktop PRE-CREATION 
>   konqueror/settings/kio/uasproviders/lynxoncurrent.desktop 57036675d9f7419e6f952fbc1c41709564bf4057 
>   konqueror/settings/kio/uasproviders/nn301oncurrent.desktop 702247f7c5a1edccf7364ee09ecd8b3781b32fe0 
>   konqueror/settings/kio/uasproviders/nn475oncurrent.desktop ac5e1fcd4a6c9617f90d7d6aa799346d224ba955 
>   konqueror/settings/kio/uasproviders/nn475onwin95.desktop f3f1920f93e448166dd174aec36ffd7e32313798 
>   konqueror/settings/kio/uasproviders/ns71oncurrent.desktop 50b3d0cca7cac210f2ac6eb7db86fda14b024b9a 
>   konqueror/settings/kio/uasproviders/ns71onwinnt51.desktop 6d5e9f1630462c997467d9a09874afd249dd5d40 
>   konqueror/settings/kio/uasproviders/op1162oncurrent.desktop PRE-CREATION 
>   konqueror/settings/kio/uasproviders/op1202oncurrent.desktop PRE-CREATION 
>   konqueror/settings/kio/uasproviders/op403onwinnt4.desktop a0caf0646f1b35bd712556087965c3ce6dbff3ac 
>   konqueror/settings/kio/uasproviders/op85oncurrent.desktop 98557fab1b5286149505d0aba2d5c9d5709d9910 
>   konqueror/settings/kio/uasproviders/op90oncurrent.desktop c8e025cafce8e7b1e2df9022aeb908fd01fb1940 
>   konqueror/settings/kio/uasproviders/op962oncurrent.desktop c7072d6424f64b132727ec61515404921e0be3ce 
>   konqueror/settings/kio/uasproviders/safari20.desktop 5ba0d25635b5cf55ec51f5ac4e2b99e08e5233c9 
>   konqueror/settings/kio/uasproviders/safari30oniphone.desktop eaacee26722e9a0997f9f9bc0e7e52f56f2384c5 
>   konqueror/settings/kio/uasproviders/safari32.desktop 5c511a6601355a8cfd064497dc74a364546dfe8b 
>   konqueror/settings/kio/uasproviders/safari40.desktop 682c1e4b84742d9d85a5397627d637404eccc47b 
>   konqueror/settings/kio/uasproviders/safari517.desktop PRE-CREATION 
>   konqueror/settings/kio/uasproviders/safari60.desktop PRE-CREATION 
>   konqueror/settings/kio/uasproviders/w3moncurrent.desktop 27160d603484857e99656caabc3a070a72119236 
> 
> Diff: http://git.reviewboard.kde.org/r/108057/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guillaume de Bure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130208/1b041378/attachment.htm>