<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108057/">http://git.reviewboard.kde.org/r/108057/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 7th, 2013, 12:33 p.m. UTC, <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please run git pull --rebase before pushing any non-merge commits to prevent polluting the logs with commits like
http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=94b3817429b470eed5687922661832b260bcc06c
Thanks.</pre>
</blockquote>
<p>On February 6th, 2013, 10:47 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Has this been commited? It has Ship it! but still shows as open in reviewboard.</pre>
</blockquote>
<p>On February 7th, 2013, 9 p.m. UTC, <b>Guillaume de Bure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship it was given for diff r1, and I did commit it.
I did not commit yet the diff r3, for various reasons (laptop died, unsure about comitting during 4.10 RC stage...). If the quality seems OK pollution wise (cf Frank's remark), I can commit it.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My comment hat nothing to do with the quality of the patch. I was just asking for keeping the logs clean by not adding a superfluous merge on top of a single commit.
If you have the commit in your master branch, just run "git pull --rebase" before you push it, and I'm happy :-)</pre>
<br />
<p>- Frank</p>
<br />
<p>On January 6th, 2013, 10:44 p.m. UTC, Guillaume de Bure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Guillaume de Bure.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2013, 10:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I find that the current list of Browser identities that you can use in konqueror or rekonq is so very obsolete... I used information from http://www.useragentstring.com/pages/Browserlist/ and wrote some additional .desktop files, specifically:
* Chrome 22, 23, 24
* Firefox 15, 16
* IE 8, 9
* Opera 11, 12
* Safari 5, 6
I purposely did not update the CMakeLists.txt yet, waiting for some initial feedback first. I also intend to remove some other entries from the current file list, unsure whether that should come in a separate review request</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/settings/kio/uasproviders/CMakeLists.txt <span style="color: grey">(6c49f42773bb20404ae94e92d8d60c49506505f5)</span></li>
<li>konqueror/settings/kio/uasproviders/android10.desktop <span style="color: grey">(07b393b631363ae8e4a12200508f331bd1fc20a5)</span></li>
<li>konqueror/settings/kio/uasproviders/android235.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/android403.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/chrome10onwinnt51.desktop <span style="color: grey">(e9f777f87872c975df69ae424f23594162f5f3e5)</span></li>
<li>konqueror/settings/kio/uasproviders/chrome23oncurrent.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/chrome24oncurrent.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/chrome50oncurrent.desktop <span style="color: grey">(401b5df32cd61f705369e719bb7f5e1376a0af9f)</span></li>
<li>konqueror/settings/kio/uasproviders/firefox15oncurrent.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/firefox16oncurrent.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/firefox20oncurrent.desktop <span style="color: grey">(1e7c477b7805be443e3513aaaf98df28d763ce46)</span></li>
<li>konqueror/settings/kio/uasproviders/firefox30oncurrent.desktop <span style="color: grey">(cc6c68f940157966a6a31dad5d65db1503a47f37)</span></li>
<li>konqueror/settings/kio/uasproviders/firefox36oncurrent.desktop <span style="color: grey">(3567a094ceb0d055f00977092431abddc5e4b9d0)</span></li>
<li>konqueror/settings/kio/uasproviders/ie401onwinnt4.desktop <span style="color: grey">(9f8a8115f10a6293fc832141b4fd6014285530f4)</span></li>
<li>konqueror/settings/kio/uasproviders/ie50onppc.desktop <span style="color: grey">(a3a833bc4040a4d17b11733b4d28ad79b8913319)</span></li>
<li>konqueror/settings/kio/uasproviders/ie55onwinnt5.desktop <span style="color: grey">(569241ac08d80adce7266c177011527916cf2b98)</span></li>
<li>konqueror/settings/kio/uasproviders/ie60oncurrent.desktop <span style="color: grey">(05ea3f11b49ff67a13e8c17b97416f84e122f552)</span></li>
<li>konqueror/settings/kio/uasproviders/ie80onwinnt60.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/ie90onwinnt71.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/lynxoncurrent.desktop <span style="color: grey">(57036675d9f7419e6f952fbc1c41709564bf4057)</span></li>
<li>konqueror/settings/kio/uasproviders/nn301oncurrent.desktop <span style="color: grey">(702247f7c5a1edccf7364ee09ecd8b3781b32fe0)</span></li>
<li>konqueror/settings/kio/uasproviders/nn475oncurrent.desktop <span style="color: grey">(ac5e1fcd4a6c9617f90d7d6aa799346d224ba955)</span></li>
<li>konqueror/settings/kio/uasproviders/nn475onwin95.desktop <span style="color: grey">(f3f1920f93e448166dd174aec36ffd7e32313798)</span></li>
<li>konqueror/settings/kio/uasproviders/ns71oncurrent.desktop <span style="color: grey">(50b3d0cca7cac210f2ac6eb7db86fda14b024b9a)</span></li>
<li>konqueror/settings/kio/uasproviders/ns71onwinnt51.desktop <span style="color: grey">(6d5e9f1630462c997467d9a09874afd249dd5d40)</span></li>
<li>konqueror/settings/kio/uasproviders/op1162oncurrent.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/op1202oncurrent.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/op403onwinnt4.desktop <span style="color: grey">(a0caf0646f1b35bd712556087965c3ce6dbff3ac)</span></li>
<li>konqueror/settings/kio/uasproviders/op85oncurrent.desktop <span style="color: grey">(98557fab1b5286149505d0aba2d5c9d5709d9910)</span></li>
<li>konqueror/settings/kio/uasproviders/op90oncurrent.desktop <span style="color: grey">(c8e025cafce8e7b1e2df9022aeb908fd01fb1940)</span></li>
<li>konqueror/settings/kio/uasproviders/op962oncurrent.desktop <span style="color: grey">(c7072d6424f64b132727ec61515404921e0be3ce)</span></li>
<li>konqueror/settings/kio/uasproviders/safari20.desktop <span style="color: grey">(5ba0d25635b5cf55ec51f5ac4e2b99e08e5233c9)</span></li>
<li>konqueror/settings/kio/uasproviders/safari30oniphone.desktop <span style="color: grey">(eaacee26722e9a0997f9f9bc0e7e52f56f2384c5)</span></li>
<li>konqueror/settings/kio/uasproviders/safari32.desktop <span style="color: grey">(5c511a6601355a8cfd064497dc74a364546dfe8b)</span></li>
<li>konqueror/settings/kio/uasproviders/safari40.desktop <span style="color: grey">(682c1e4b84742d9d85a5397627d637404eccc47b)</span></li>
<li>konqueror/settings/kio/uasproviders/safari517.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/safari60.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/w3moncurrent.desktop <span style="color: grey">(27160d603484857e99656caabc3a070a72119236)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108057/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>