Review Request 108727: ktimezoned: Watch /etc/localtime if it doesn't exist yet.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108727/#review26711
-----------------------------------------------------------


Looks ok to me, although I don't really know this code.

- David Faure


On Feb. 3, 2013, 4:30 a.m., Kevin Kofler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108727/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2013, 4:30 a.m.)
> 
> 
> Review request for KDE Runtime and David Jarvie.
> 
> 
> Description
> -------
> 
> /etc/localtime legitimately might not exist. The default is then UTC. But the file can then be created later, so watch for its creation.
> 
> If we don't do this, when setting the time zone for the first time using kcm_clock, the initially set time zone will fail to get reloaded and the dialog will unexpectedly jump back to UTC.
> 
> This problem shows up on Fedora 18, see:
> https://bugzilla.redhat.com/show_bug.cgi?id=906972
> 
> Please note that to test the fix with kcm_clock, you also need the kcm_clock (kde-workspace) fix from:
> https://git.reviewboard.kde.org/r/108711/
> (which is already approved and which I'll push to KDE/4.10 and merge to master as soon as the 4.10.0 tagging freeze is lifted).
> 
> 
> Diffs
> -----
> 
>   ktimezoned/ktimezoned.cpp 4eafa4e 
> 
> Diff: http://git.reviewboard.kde.org/r/108727/diff/
> 
> 
> Testing
> -------
> 
> Builds against at least 4.10.0 and 4.9.5.
> 
> Works at runtime (and appears to fix the bug): https://bugzilla.redhat.com/show_bug.cgi?id=906972#c5
> 
> 
> Thanks,
> 
> Kevin Kofler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130205/87267214/attachment.htm>