Moving Baloo and Baloo-widgets into KDE SC
David Edmundson
david at davidedmundson.co.uk
Wed Dec 25 20:24:15 GMT 2013
Vishesh,
Review of the folder "core"
itemtype.h is useless.
- it is not namespaced and it doesn't do anything.
datastore.h
- it's public, so should use a d-pointer.
query.cpp
- you don't delete d ?
- there's a few things still TODO
result.h
does it make sense to use Baloo::Item::Id instead of QByteArray?
term.h
why have isNegated() and negated() they appear to be identical.
Will review other folders throughout the week.
More information about the kde-core-devel
mailing list