Review Request 112173: Do not use QFileInfo to obtain the size of a symlink in kio_trash

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112173/
-----------------------------------------------------------

Status
------

This change has been marked as submitted.


Review request for KDE Runtime, David Faure and Tobias Koenig.


Description
-------

The attached patch fixes a bug where deleting a symlink to a very large file causes a "trash has reached its limit error. This happens because the code that is used to determine the amount of space available in the trashcan uses QFileInfo::size to determine the size of a file. This will not work because QFileInfo::size returns the size of the actual file the symlink points to and not the size of the symlink itself. See the documentation for QFileInfo.


This addresses bug 253776.
    http://bugs.kde.org/show_bug.cgi?id=253776


Diffs
-----

  kioslave/trash/discspaceutil.cpp 8e76ece 

Diff: http://git.reviewboard.kde.org/r/112173/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130821/c3cf0f17/attachment.htm>