Review Request 112144: Smal KXmlGuiWindow documentation improvements

[Albert Astals Cid]

> On Aug. 19, 2013, 5:06 p.m., David Faure wrote:
> > This patch looks OK.
> > 
> > Deprecating it, I'm not sure. Please investigate porting some kde4 apps from createGUI to setupGUI to see what's actually involved in that.
> 
> Albert Astals Cid wrote:
>     This is what is involved. Less code, less bugs.
>     
>     http://quickgit.kde.org/?p=krdc.git&a=commit&h=0233f23b99095d641336fb6fad080b62852ddcc9
> 
> David Faure wrote:
>     Yes, for "simple apps", definitely. I'm just wondering if some other more advanced use cases create more trouble, i.e. whether there's still a valid use case for createGUI somewhere hidden.
>     But it might be that the flags for setupGUI make all cases possible, I'm not sure.

If you have anythin in mind, i'll be happy to have a look.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112144/#review38159
-----------------------------------------------------------


On Aug. 19, 2013, 6:18 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112144/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 6:18 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Suggest people to use setupGUI instead of createGUI.
> 
> Also mention in setHelpMenuEnabled that it will affect setupGUI
> 
> I was going to suggest to actually deprecate createGUI but maybe it is too much for 4.x, but maybe in frameworks?
> 
> 
> Diffs
> -----
> 
>   kdeui/xmlgui/kxmlguiwindow.h 3237b8c 
> 
> Diff: http://git.reviewboard.kde.org/r/112144/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130820/5cb7e990/attachment.htm>