Review Request 112144: Smal KXmlGuiWindow documentation improvements
Commit Hook
null at kde.org
Mon Aug 19 19:18:18 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112144/#review38165
-----------------------------------------------------------
This review has been submitted with commit c75f908c280733e3d12e5ad51268eba0ee5d97bc by Albert Astals Cid to branch master.
- Commit Hook
On Aug. 18, 2013, 2:15 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112144/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2013, 2:15 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Description
> -------
>
> Suggest people to use setupGUI instead of createGUI.
>
> Also mention in setHelpMenuEnabled that it will affect setupGUI
>
> I was going to suggest to actually deprecate createGUI but maybe it is too much for 4.x, but maybe in frameworks?
>
>
> Diffs
> -----
>
> kdeui/xmlgui/kxmlguiwindow.h 3237b8c
>
> Diff: http://git.reviewboard.kde.org/r/112144/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130819/78483676/attachment.htm>
More information about the kde-core-devel
mailing list