Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

[Sebastian Kügler]

> On Aug. 17, 2013, 8:26 a.m., Marco Martin wrote:
> > Hmm, not sure about it, the packages were defined as archives with metadata.desktop in the root, this would basically allow a quirks mode, do we want to support malformed packages?
> 
> Jeremy Paul Whiting wrote:
>     Ok, I just tried repackaging Helium from kde-look.org with the contents directly in the .tar.xz rather than in a subfolder Helium. With my other plasmapkg patch that installs and uninstalls just fine. So the question then becomes are these themes on kde-look.org packaged with some tool? or just packaged by hand incorrectly? If it's a tool that's creating them, we ought to fix the tool, otherwise I guess I can go through the themes on kde-look.org and suggest they repackage them correctly.

It's at least not possible with plasmapkg, as this tool checks for metadata.desktop, and only if it exists in the to-package-directory, will actually work.

I suppose it's a hand-packaged package, done wrong.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112129/#review38015
-----------------------------------------------------------


On Aug. 17, 2013, 3:06 a.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112129/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 3:06 a.m.)
> 
> 
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> This is the other half of the fix for the listed bug.  I made Plasma::PackageStructure::metadata look in the only subdirectory of an extracted archive if there's only one subdirectory for the metadata.desktop file.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=149479.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479
> 
> 
> Diffs
> -----
> 
>   plasma/packagestructure.cpp 71148e1a18227d9ca847cbffe385aaaad9c66c6b 
> 
> Diff: http://git.reviewboard.kde.org/r/112129/diff/
> 
> 
> Testing
> -------
> 
> The bug is fixed here with this and my other patch. Any better ideas for getting the only subdirectory are welcome, it feels a bit kludgy as is.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130820/089eedff/attachment.htm>