Review Request 112144: Smal KXmlGuiWindow documentation improvements

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112144/#review38159
-----------------------------------------------------------

Ship it!


This patch looks OK.

Deprecating it, I'm not sure. Please investigate porting some kde4 apps from createGUI to setupGUI to see what's actually involved in that.

- David Faure


On Aug. 18, 2013, 2:15 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112144/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 2:15 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Suggest people to use setupGUI instead of createGUI.
> 
> Also mention in setHelpMenuEnabled that it will affect setupGUI
> 
> I was going to suggest to actually deprecate createGUI but maybe it is too much for 4.x, but maybe in frameworks?
> 
> 
> Diffs
> -----
> 
>   kdeui/xmlgui/kxmlguiwindow.h 3237b8c 
> 
> Diff: http://git.reviewboard.kde.org/r/112144/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130819/85fb74c6/attachment.htm>