Review Request 112144: Smal KXmlGuiWindow documentation improvements

Jeremy Paul Whiting jpwhiting at kde.org
Mon Aug 19 18:04:05 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112144/#review38157
-----------------------------------------------------------

Ship it!


Ship It!

- Jeremy Paul Whiting


On Aug. 18, 2013, 8:15 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112144/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 8:15 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Suggest people to use setupGUI instead of createGUI.
> 
> Also mention in setHelpMenuEnabled that it will affect setupGUI
> 
> I was going to suggest to actually deprecate createGUI but maybe it is too much for 4.x, but maybe in frameworks?
> 
> 
> Diffs
> -----
> 
>   kdeui/xmlgui/kxmlguiwindow.h 3237b8c 
> 
> Diff: http://git.reviewboard.kde.org/r/112144/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130819/fa6cad2a/attachment.htm>


More information about the kde-core-devel mailing list