Review Request 111992: Activity bar in QML.

[Bhushan Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992/
-----------------------------------------------------------

(Updated Aug. 13, 2013, 4:11 a.m.)


Review request for kde-workspace and Marco Martin.


Changes
-------

1) Set minimum height and width to implicit width/height.
2) Rotated tabBar when formFactor is vertical, but it looks *very* wired. 

Added a bug in qml-components component for this (Bug #323443). I think all issues are resolved!(?)


Description
-------

Activity bar applet ported in QML.


Diffs (updated)
-----

  plasma/generic/applets/activitybar/Messages.sh e73df21 
  plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb 
  plasma/generic/applets/activitybar/activitybar.h b95cb0c 
  plasma/generic/applets/activitybar/activitybar.cpp e66bf04 
  plasma/generic/applets/activitybar/package/contents/ui/main.qml PRE-CREATION 
  plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION 
  plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop b7155de 

Diff: http://git.reviewboard.kde.org/r/111992/diff/


Testing
-------

Works, Tested in plasmoidviewer and desktop


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130813/0ff4bba9/attachment.htm>