<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111992/">http://git.reviewboard.kde.org/r/111992/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for kde-workspace and Marco Martin.</div>
<div>By Bhushan Shah.</div>


<p style="color: grey;"><i>Updated Aug. 13, 2013, 4:11 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) Set minimum height and width to implicit width/height.
2) Rotated tabBar when formFactor is vertical, but it looks *very* wired. 

Added a bug in qml-components component for this (Bug #323443). I think all issues are resolved!(?)</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Activity bar applet ported in QML.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works, Tested in plasmoidviewer and desktop</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/activitybar/Messages.sh <span style="color: grey">(e73df21)</span></li>

 <li>plasma/generic/applets/activitybar/CMakeLists.txt <span style="color: grey">(51a2edb)</span></li>

 <li>plasma/generic/applets/activitybar/activitybar.h <span style="color: grey">(b95cb0c)</span></li>

 <li>plasma/generic/applets/activitybar/activitybar.cpp <span style="color: grey">(e66bf04)</span></li>

 <li>plasma/generic/applets/activitybar/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/activitybar/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop <span style="color: grey">(b7155de)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111992/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>