Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap
Ömer Fadıl Usta
omerusta at gmail.com
Tue Apr 30 10:04:02 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110138/
-----------------------------------------------------------
(Updated April 30, 2013, 12:04 p.m.)
Review request for kdelibs, Aaron J. Seigo, Martin Gräßlin, and Marco Martin.
Changes
-------
This is the final (i hope :) ) shape of patch.
Compiled and working fine
Description (updated)
-------
I was getting lots of errors while moving my mouse over system tray before this patch.
Also this patch fixes a forgetten check before freeing a already undefined pixmap
Diffs (updated)
-----
plasma/private/dialogshadows.cpp 89814ec
Diff: http://git.reviewboard.kde.org/r/110138/diff/
Testing
-------
Looks like it is working fine
Thanks,
Ömer Fadıl Usta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130430/f828d67f/attachment.htm>
More information about the kde-core-devel
mailing list