Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

Ömer Fadıl Usta omerusta at
Sat Apr 27 10:04:24 BST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated April 27, 2013, 12:04 p.m.)

Review request for kdelibs, Aaron J. Seigo, Martin Gräßlin, and Marco Martin.


In this patch there is 2 patches 1 from :
and 1 is from mine. I have to combine 2 of them because even first one get a "ship it"
it didn't committed yet so i have to add it to show you complete one. Otherwise i need
to wait until it committed than make my diff on that one.

So mine part is almost useless but gets away lots of warnings which makes me sick of them.


I was getting lots of errors while moving my mouse over system tray before this patch.( ) 
Also this patch fixes a forgetten check before freeing a already freed pixmap

Diffs (updated)

  plasma/private/dialogshadows.cpp e787fd4 
  plasma/private/dialogshadows_p.h a2d62cc 



Looks like it is working fine


Ömer Fadıl Usta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list