Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

Ömer Fadıl Usta omerusta at gmail.com
Sat Apr 27 05:16:53 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110138/
-----------------------------------------------------------

(Updated April 27, 2013, 7:16 a.m.)


Review request for kdelibs, Aaron J. Seigo, Martin Gräßlin, and Marco Martin.


Changes
-------

My patched patch over Aurélien Gâteau's patch ( https://git.reviewboard.kde.org/r/110208/diff/ ) :)


Description
-------

I was getting lots of errors while moving my mouse over system tray before this patch.( http://paste.kde.org/730880/ ) 
Also this patch fixes a forgetten check before freeing a already freed pixmap


Diffs (updated)
-----

  plasma/private/dialogshadows_p.h a2d62cc 
  plasma/private/dialogshadows.cpp e787fd4 

Diff: http://git.reviewboard.kde.org/r/110138/diff/


Testing
-------

Looks like it is working fine


Thanks,

Ömer Fadıl Usta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130427/753fec53/attachment.htm>


More information about the kde-core-devel mailing list