Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110138/#review31469
-----------------------------------------------------------



plasma/private/dialogshadows.cpp
<http://git.reviewboard.kde.org/r/110138/#comment23453>

    if (!pix.isNull()) {
    Also watch the brace position.



plasma/private/dialogshadows.cpp
<http://git.reviewboard.kde.org/r/110138/#comment23454>

    if (!size.isEmpty()) {
       QPixmap tempEmptyPix = ...
    }
    #endif
    return QPixmap();
    }



plasma/private/dialogshadows.cpp
<http://git.reviewboard.kde.org/r/110138/#comment23456>

    fyi, this is not "freeing of an already freed pixmap" (that would imply a crash, but is not possible like with eg. XFree()) but freeing an undefined pixmap.


- Thomas Lübking


On April 23, 2013, 10:40 p.m., Ömer Fadıl Usta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110138/
> -----------------------------------------------------------
> 
> (Updated April 23, 2013, 10:40 p.m.)
> 
> 
> Review request for kdelibs, Aaron J. Seigo, Martin Gräßlin, and Marco Martin.
> 
> 
> Description
> -------
> 
> I was getting lots of errors while moving my mouse over system tray before this patch.( http://paste.kde.org/730880/ ) 
> Also this patch fixes a forgetten check before freeing a already freed pixmap
> 
> 
> Diffs
> -----
> 
>   plasma/private/dialogshadows.cpp e787fd4 
> 
> Diff: http://git.reviewboard.kde.org/r/110138/diff/
> 
> 
> Testing
> -------
> 
> Looks like it is working fine
> 
> 
> Thanks,
> 
> Ömer Fadıl Usta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130423/5fc455c3/attachment.htm>