Review Request 110110: Add Musics , Downloads , Videos, Pictures places bookmarks to kfileplacesmodal

Thomas Lübking thomas.luebking at gmail.com
Tue Apr 23 09:17:04 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110110/#review31438
-----------------------------------------------------------


there's hardly a point in creating the instance on the heap and a KUser instance is required right above, so you could create one (on the stack) and use it in both occasions.

- Thomas Lübking


On April 23, 2013, 5:08 a.m., Ömer Fadıl Usta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110110/
> -----------------------------------------------------------
> 
> (Updated April 23, 2013, 5:08 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Add Musics , Downloads , Videos, Pictures places bookmarks to kfileplacesmodal
> Patch from Mandriva Linux
> 
> 
> Diffs
> -----
> 
>   kfile/kfileplacesmodel.cpp a73274c 
> 
> Diff: http://git.reviewboard.kde.org/r/110110/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ömer Fadıl Usta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130423/429eb62c/attachment.htm>


More information about the kde-core-devel mailing list