Review Request 110084: Make ftp error messages prettier

[Thomas Lübking]

> On April 19, 2013, 1:13 p.m., David Faure wrote:
> > Well, yes, it looks nicer to my eyes because I'm not very good at german (and your "before" screenshot is in german) :-P
> > 
> > More seriously I'm not sure this will always work... what if the error message is much longer? Shouldn't it start on its own line so we don't confuse it with the kio_ftp-provided sentence, in general?

What esp. should not happen is to just print "421" but indicate that this is "Error #421" or similar.

More 2¢:
For more visual appeal i'd suggest to emphasize the upper (main) line (h2 or maybe just b), get rid of the empty line(s? - trailing one) and ideally get the close button top aligned (esp. since it almost looks like the icon...)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110084/#review31289
-----------------------------------------------------------


On April 19, 2013, 1:08 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110084/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 1:08 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Remove linebreaks and trim the message so the ugly linebreak at the end disappears.
> 
> 
> This addresses bug 318079.
>     http://bugs.kde.org/show_bug.cgi?id=318079
> 
> 
> Diffs
> -----
> 
>   kioslave/ftp/ftp.cpp b0868d8 
> 
> Diff: http://git.reviewboard.kde.org/r/110084/diff/
> 
> 
> Testing
> -------
> 
> Works and looks much nicer :)
> 
> 
> File Attachments
> ----------------
> 
> Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png
> After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130419/3822edc1/attachment.htm>