Review Request 109997: Tint selected icon in KFileItemDelegate by highlight color (as Dolphin 2.0)

[Frank Reininghaus]

> On April 13, 2013, 5 p.m., Christoph Feck wrote:
> > Regarding the icon tinting, there are bugs filed against this Dolphin behavior, so I am not sure we should replicate it in kdelibs.
> 
> Christoph Feck wrote:
>     bug 304643, bug 309722 to be more specific :)
> 
> Eike Hein wrote:
>     In the meantime, the matching patch for Folder View was approved by plasma-devel and committed to the 4.10 and master branches. My opinion is that we should keep things consistent; if Dolphin decides to abandon this look again we can do so in the other places as well (if I forget you can call me out for it I guess).

I fully agree with Christoph. The tinting is a very bad solution, and removing it in Dolphin is on my (far too long considering how much time I can spend on KDE) TODO-list.

Some more information:

a) The tinting was not introduced in Dolphin 2.0, but in Dolphin 2.1 (KDE 4.9) because some people thought that just highlighting the file name was not enough. See bug 295515, where the first complaints about the tinting were raised as soon as the commit happened.

b) There has also been a forum discussion about this: http://forum.kde.org/viewtopic.php?f=224&t=108409 . Peter, who added the tinting in the first place, suggested to reduce the tinting level as a short-term solution to make it less ugly.

c) I did some tests with different tinting levels: http://bugsfiles.kde.org/attachment.cgi?id=76313 (decreases from 1.0, the KDE 4.9 value, to 0.4 in steps of 0.1). You can see that it's impossible to find a value that makes blue selected icons recognizable and at the same time makes selected previews not look ugly. I thought that 0.8 might be the least ugly version and used that compromise for Dolphin 2.2 (KDE 4.10) because any real fix for this issue would have required more intrusive code changes.

I think that Dolphin should actually better be changed to use the same highlighting as KFileItemDelegate.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109997/#review30996
-----------------------------------------------------------


On April 13, 2013, 3:12 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109997/
> -----------------------------------------------------------
> 
> (Updated April 13, 2013, 3:12 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> As of Dolphin 2.0, Dolphin tints the icons of selected file items by the palette's highlight color. This patch adapts the KFileItemDelegate rendering code to mirror this Dolphin behavior for consistency.
> 
> A similar review request was filed against Folder View: https://git.reviewboard.kde.org/r/109995/
> 
> 
> Diffs
> -----
> 
>   kio/kio/kfileitemdelegate.cpp 50cc3b6 
> 
> Diff: http://git.reviewboard.kde.org/r/109997/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Before/after in KFileDialog
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/13/tint.png
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130415/5d9fa9c3/attachment.htm>