Review Request 109997: Tint selected icon in KFileItemDelegate by highlight color (as Dolphin 2.0)

[Eike Hein]

> On April 13, 2013, 5 p.m., Christoph Feck wrote:
> > Regarding the icon tinting, there are bugs filed against this Dolphin behavior, so I am not sure we should replicate it in kdelibs.
> 
> Christoph Feck wrote:
>     bug 304643, bug 309722 to be more specific :)

In the meantime, the matching patch for Folder View was approved by plasma-devel and committed to the 4.10 and master branches. My opinion is that we should keep things consistent; if Dolphin decides to abandon this look again we can do so in the other places as well (if I forget you can call me out for it I guess).


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109997/#review30996
-----------------------------------------------------------


On April 13, 2013, 3:12 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109997/
> -----------------------------------------------------------
> 
> (Updated April 13, 2013, 3:12 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> As of Dolphin 2.0, Dolphin tints the icons of selected file items by the palette's highlight color. This patch adapts the KFileItemDelegate rendering code to mirror this Dolphin behavior for consistency.
> 
> A similar review request was filed against Folder View: https://git.reviewboard.kde.org/r/109995/
> 
> 
> Diffs
> -----
> 
>   kio/kio/kfileitemdelegate.cpp 50cc3b6 
> 
> Diff: http://git.reviewboard.kde.org/r/109997/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Before/after in KFileDialog
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/13/tint.png
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130415/f5cf4dae/attachment.htm>