Review Request 109935: Make KFilePlacesModel treats internal moves by drag'n'drop as moves instead of remove+insert

[Aurélien Gâteau]

> On April 11, 2013, 2:03 p.m., Commit Hook wrote:
> > This review has been submitted with commit 8f8e3c27005b9d32b31cb6de5fd162a68c2a736b by Aurélien Gâteau to branch master.

I decided to push it to master and not to KDE/4.10 as this could be disruptive.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109935/#review30912
-----------------------------------------------------------


On April 11, 2013, 2:03 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109935/
> -----------------------------------------------------------
> 
> (Updated April 11, 2013, 2:03 p.m.)
> 
> 
> Review request for kdelibs and Kevin Ottens.
> 
> 
> Description
> -------
> 
> When user moves an item from the model by dragging it, KFilePlacesModel removes the item row and adds it back at the new position. This patch changes this behavior to use beginMoveRows() and endMoveRows() instead.
> 
> I came upon this while implementing drag'n'drop to reorder items in Homerun. Homerun uses KFilePlacesModel in the "favorite places" source, and the reordering code expects the model to use beginMoveRows() and endMoveRows().
> 
> 
> Diffs
> -----
> 
>   kfile/kfileplacesmodel.cpp 0192926233bac62596e4c04b9267229f4a284c95 
>   kfile/tests/kfileplacesmodeltest.cpp 2ae9b7548e47985369dc896086031c07bf0c5a4c 
> 
> Diff: http://git.reviewboard.kde.org/r/109935/diff/
> 
> 
> Testing
> -------
> 
> Tested with Homerun and other applications using KFileDialog. Updated the unit-tests.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130411/2a0bb131/attachment.htm>