Review Request 109935: Make KFilePlacesModel treats internal moves by drag'n'drop as moves instead of remove+insert

Commit Hook null at
Thu Apr 11 13:03:53 BST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated April 11, 2013, 12:03 p.m.)


This change has been marked as submitted.

Review request for kdelibs and Kevin Ottens.


When user moves an item from the model by dragging it, KFilePlacesModel removes the item row and adds it back at the new position. This patch changes this behavior to use beginMoveRows() and endMoveRows() instead.

I came upon this while implementing drag'n'drop to reorder items in Homerun. Homerun uses KFilePlacesModel in the "favorite places" source, and the reordering code expects the model to use beginMoveRows() and endMoveRows().


  kfile/kfileplacesmodel.cpp 0192926233bac62596e4c04b9267229f4a284c95 
  kfile/tests/kfileplacesmodeltest.cpp 2ae9b7548e47985369dc896086031c07bf0c5a4c 



Tested with Homerun and other applications using KFileDialog. Updated the unit-tests.


Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list