Review Request 109814: bump workspace to require Qt 4.8.0
Thomas Lübking
thomas.luebking at gmail.com
Mon Apr 1 19:29:54 BST 2013
> On April 1, 2013, 6:12 p.m., John Layt wrote:
> > All changes in requirements should be discussed on the k-c-d mailing list first.
What we just do (k-c-d is CC'd as group on the RR)
Though I just noticed that the dated kdelibs version required in master (4.9.4) does not have the Qt 4.8.0 requirement, so this is not just a technical thing and indeed means it has to be resolved whether kde-workspace 4.11 on kdelibs 4.9.x is indeed a valid case.
I'm not gonna push this until that aspect is sufficiently resolved.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109814/#review30222
-----------------------------------------------------------
On April 1, 2013, 5:47 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109814/
> -----------------------------------------------------------
>
> (Updated April 1, 2013, 5:47 p.m.)
>
>
> Review request for kde-workspace.
>
>
> Description
> -------
>
> http://git.reviewboard.kde.org/r/109784/ requires a Qt 4.8 feature and kdelibs/CMakeLists.txt already has
>
> set (QT_MIN_VERSION "4.8.0")
>
> so there's implicit requirement for it in kde-workspace as well, really no point in not bumping and just honest to do so.
>
> I'll intend to push this into master (for 4.11) next Sunday - so if you've concerns or think someone else needs to be added to the request, please yell until then.
>
> (inb4: "No, it's not an April fool")
>
>
> Diffs
> -----
>
> CMakeLists.txt 06b779b
>
> Diff: http://git.reviewboard.kde.org/r/109814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Lübking
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130401/39acf3e8/attachment.htm>
More information about the kde-core-devel
mailing list