<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109814/">http://git.reviewboard.kde.org/r/109814/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 1st, 2013, 6:12 p.m. UTC, <b>John Layt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All changes in requirements should be discussed on the k-c-d mailing list first.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What we just do (k-c-d is CC'd as group on the RR)
Though I just noticed that the dated kdelibs version required in master (4.9.4) does not have the Qt 4.8.0 requirement, so this is not just a technical thing and indeed means it has to be resolved whether kde-workspace 4.11 on kdelibs 4.9.x is indeed a valid case.
I'm not gonna push this until that aspect is sufficiently resolved.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On April 1st, 2013, 5:47 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated April 1, 2013, 5:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://git.reviewboard.kde.org/r/109784/ requires a Qt 4.8 feature and kdelibs/CMakeLists.txt already has
set (QT_MIN_VERSION "4.8.0")
so there's implicit requirement for it in kde-workspace as well, really no point in not bumping and just honest to do so.
I'll intend to push this into master (for 4.11) next Sunday - so if you've concerns or think someone else needs to be added to the request, please yell until then.
(inb4: "No, it's not an April fool")</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(06b779b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109814/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>