Review Request: Hide empty additional information lines in icons view mode

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106304/#review19397
-----------------------------------------------------------


Unfortunately, there were really some problems due to this fix in master (icons jumping around unexpectedly in the view while info was retrieved asynchronously because the number of rows required by each item could change, see comments in https://bugs.kde.org/show_bug.cgi?id=304752 ). Nontheless, the idea was very nice and looked good at first sight, and we still have the part of the patch that removes the annoying "-" in 4.9 and master, so thanks again for looking into this, Todd!

- Frank Reininghaus


On Sept. 3, 2012, 11:29 p.m., Todd Jennings wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106304/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2012, 11:29 p.m.)
> 
> 
> Review request for Dolphin and KDE Base Apps.
> 
> 
> Description
> -------
> 
> Hide empty additional information lines in icons view mode.  Previously they were "-", which took up a lot of space while providing no additional information.
> 
> 
> This addresses bug 304752.
>     http://bugs.kde.org/show_bug.cgi?id=304752
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/knepomukrolesprovider.cpp 0ae9b6bd3edf88ea48c40bb491ef9e57148b8062 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 7ae7e2efcffc2f68c72a05cdbc3b29abc4c3aff4 
> 
> Diff: http://git.reviewboard.kde.org/r/106304/diff/
> 
> 
> Testing
> -------
> 
> Tested and it works
> 
> 
> Thanks,
> 
> Todd Jennings
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120924/cd6e0d14/attachment.htm>