<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106304/">http://git.reviewboard.kde.org/r/106304/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unfortunately, there were really some problems due to this fix in master (icons jumping around unexpectedly in the view while info was retrieved asynchronously because the number of rows required by each item could change, see comments in https://bugs.kde.org/show_bug.cgi?id=304752 ). Nontheless, the idea was very nice and looked good at first sight, and we still have the part of the patch that removes the annoying "-" in 4.9 and master, so thanks again for looking into this, Todd!</pre>
<br />
<p>- Frank</p>
<br />
<p>On September 3rd, 2012, 11:29 p.m., Todd Jennings wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin and KDE Base Apps.</div>
<div>By Todd Jennings.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2012, 11:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hide empty additional information lines in icons view mode. Previously they were "-", which took up a lot of space while providing no additional information.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested and it works</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304752">304752</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/private/knepomukrolesprovider.cpp <span style="color: grey">(0ae9b6bd3edf88ea48c40bb491ef9e57148b8062)</span></li>
<li>dolphin/src/kitemviews/kstandarditemlistwidget.cpp <span style="color: grey">(7ae7e2efcffc2f68c72a05cdbc3b29abc4c3aff4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106304/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>