Review Request: add kimgio WebP image format plugin

[Christoph Feck]

> On Sept. 1, 2012, 1:20 p.m., Christoph Feck wrote:
> > kimgio/webp.cpp, line 49
> > <http://git.reviewboard.kde.org/r/106300/diff/1/?file=82610#file82610line49>
> >
> >     Needs to check image.isValid() before writing data via scanLine() pointers. The allocation may fail because of too large width*height.
> >     
> >     Additionally, I would like the loader to return a Format_RGB32 image, when the data did not contain an alpha component.
> 
> Martin Koller wrote:
>     QImage has no isValid() method. Also I find no hint in QImage docu that it _can_ be invalid after this constructor.
>     
>     Regarding alpha: the version of the WebP library I have installed on openSuse 12.1 (0.1.2) does not have
>     a function to check if the image has alpha data.
>     On the Google page https://developers.google.com/speed/webp/docs/api?hl=ru
>     I find the function WebPGetFeatures() but as said, my version does not have it.
>

Sorry, I meant isNull(). Since a constructor has no return code, a failed allocation results in a null image.

If your version has no way to detect alpha component, then use a newer version. If the newest libwebp does not return that information, then wait until its developers wake up (a joggle them).


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106300/#review18386
-----------------------------------------------------------


On Sept. 1, 2012, 9:23 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106300/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2012, 9:23 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru
> 
> The patch is missing a cmake rule to make it optional, though, but I sent a mail to KDE-core list in the hope someone knows...
> 
> 
> This addresses bug 267365.
>     http://bugs.kde.org/show_bug.cgi?id=267365
> 
> 
> Diffs
> -----
> 
>   kimgio/CMakeLists.txt 26329c0 
>   kimgio/webp.cpp PRE-CREATION 
>   kimgio/webp.desktop PRE-CREATION 
>   kimgio/webp.h PRE-CREATION 
>   mimetypes/kde.xml a82b87c 
> 
> Diff: http://git.reviewboard.kde.org/r/106300/diff/
> 
> 
> Testing
> -------
> 
> some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality)
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120902/9c0674e2/attachment.htm>