Review Request: add kimgio WebP image format plugin

[Martin Koller]

> On Sept. 1, 2012, 1:20 p.m., Christoph Feck wrote:
> > kimgio/webp.cpp, line 5
> > <http://git.reviewboard.kde.org/r/106300/diff/1/?file=82610#file82610line5>
> >
> >     We need to be more verbose here, it has to state the versions, and a pointer where to get the license text. Please check the KDE licensing page for correct texts.

Note: I copied the license lines from xview.cpp
I've changed my files now according to the KDE policy, but probably someone should also change the older files


> On Sept. 1, 2012, 1:20 p.m., Christoph Feck wrote:
> > kimgio/webp.cpp, line 49
> > <http://git.reviewboard.kde.org/r/106300/diff/1/?file=82610#file82610line49>
> >
> >     Needs to check image.isValid() before writing data via scanLine() pointers. The allocation may fail because of too large width*height.
> >     
> >     Additionally, I would like the loader to return a Format_RGB32 image, when the data did not contain an alpha component.

QImage has no isValid() method. Also I find no hint in QImage docu that it _can_ be invalid after this constructor.

Regarding alpha: the version of the WebP library I have installed on openSuse 12.1 (0.1.2) does not have
a function to check if the image has alpha data.
On the Google page https://developers.google.com/speed/webp/docs/api?hl=ru
I find the function WebPGetFeatures() but as said, my version does not have it.


> On Sept. 1, 2012, 1:20 p.m., Christoph Feck wrote:
> > kimgio/webp.cpp, line 87
> > <http://git.reviewboard.kde.org/r/106300/diff/1/?file=82610#file82610line87>
> >
> >     Same here, should handle pure RGB case.

Same problem as above.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106300/#review18386
-----------------------------------------------------------


On Sept. 1, 2012, 8:33 a.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106300/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2012, 8:33 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru
> 
> The patch is missing a cmake rule to make it optional, though, but I sent a mail to KDE-core list in the hope someone knows...
> 
> 
> This addresses bug 267365.
>     http://bugs.kde.org/show_bug.cgi?id=267365
> 
> 
> Diffs
> -----
> 
>   kimgio/webp.cpp PRE-CREATION 
>   kimgio/webp.desktop PRE-CREATION 
>   kimgio/webp.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106300/diff/
> 
> 
> Testing
> -------
> 
> some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality)
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120901/6b1ec236/attachment.htm>