Review LibKdeAccessibilityClient

Frederik Gladhorn gladhorn at kde.org
Mon Oct 8 12:01:11 BST 2012


S√łndag 7. oktober 2012 21.45.17 skrev Alexander Neundorf:
> On Thursday 04 October 2012, Frederik Gladhorn wrote:
> > Hi,
> > 
> > so after we took the time to hack a bit more on the library in Randa,
> > I would be happy about more comments.
> 
> Why does it use KDEPIMLIBS_INSTALL_DIR ?
> 
> macro(MAKE_INSTALL_PATH_ABSOLUTE out in)
>    if (IS_ABSOLUTE "${in}")    # IS_ABSOLUTE is new since cmake 2.4.8
>       set(${out} "${in}")
>    else()
>       set(${out} "\${KDEPIMLIBS_INSTALL_DIR}/${in}")
>    endif()
> endmacro(MAKE_INSTALL_PATH_ABSOLUTE out in)
> 
> 
> I would have expected ${CMAKE_INSTALL_PREFIX}.
Thanks, fixed.

Greetings
Frederik

> 
> Alex




More information about the kde-core-devel mailing list