Review Request: Add pkgconfig hints to FindSamba.cmake

[Rex Dieter]

> On Oct. 15, 2012, 6:19 a.m., Rolf Eike Beer wrote:
> > cmake/modules/FindSamba.cmake, line 20
> > <http://git.reviewboard.kde.org/r/106861/diff/1/?file=89943#file89943line20>
> >
> >     Why the if? If there is no pkgconfig found it the macro will just do nothing. And pkgconfig could even work on Windows if it is properly installed.

I'd just followed the example of several other Find*.cmake files, like FindLibXslt.cmake that do the same thing.  I'll drop it in the next iteration


- Rex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106861/#review20357
-----------------------------------------------------------


On Oct. 14, 2012, 11:43 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106861/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2012, 11:43 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Add pkgconfig hints to FindSamba.cmake, helps find samba4 libs on non-standard-ish locations.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindSamba.cmake 16522c6 
> 
> Diff: http://git.reviewboard.kde.org/r/106861/diff/
> 
> 
> Testing
> -------
> 
> Tested on fedora 18 against samba-4.0-rc2
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121015/feea5428/attachment.htm>