Review Request: Add pkgconfig hints to FindSamba.cmake

[Rolf Eike Beer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106861/#review20357
-----------------------------------------------------------



cmake/modules/FindSamba.cmake
<http://git.reviewboard.kde.org/r/106861/#comment16103>

    Why the if? If there is no pkgconfig found it the macro will just do nothing. And pkgconfig could even work on Windows if it is properly installed.



cmake/modules/FindSamba.cmake
<http://git.reviewboard.kde.org/r/106861/#comment16101>

    trailing whitespace



cmake/modules/FindSamba.cmake
<http://git.reviewboard.kde.org/r/106861/#comment16104>

    That should be HINTS:
    
    From cmake help:
    
    Search the paths specified by the HINTS option. These should be paths computed by system introspection, such as a hint provided by the location of another item already found. Hard-coded guesses should be specified with the PATHS option.



cmake/modules/FindSamba.cmake
<http://git.reviewboard.kde.org/r/106861/#comment16102>

    trailing whitespace



cmake/modules/FindSamba.cmake
<http://git.reviewboard.kde.org/r/106861/#comment16105>

    HINTS


- Rolf Eike Beer


On Oct. 14, 2012, 11:43 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106861/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2012, 11:43 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Add pkgconfig hints to FindSamba.cmake, helps find samba4 libs on non-standard-ish locations.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindSamba.cmake 16522c6 
> 
> Diff: http://git.reviewboard.kde.org/r/106861/diff/
> 
> 
> Testing
> -------
> 
> Tested on fedora 18 against samba-4.0-rc2
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121015/61c66bab/attachment.htm>