Review Request: Show mtp devices in kfileplacesview

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106657/#review19671
-----------------------------------------------------------



kfile/kfileplacesitem.cpp
<http://git.reviewboard.kde.org/r/106657/#comment15651>

    Probably keep the empty line after that one.



kfile/kfileplacesmodel.cpp
<http://git.reviewboard.kde.org/r/106657/#comment15650>

    Wouldn't it be better to check if the mtp protocol is known by KIO at the time the predicate is built?
    
    If I'm not mistaken that would completely remove the need for that method.


- Kevin Ottens


On Sept. 30, 2012, 12:28 a.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106657/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2012, 12:28 a.m.)
> 
> 
> Review request for kdelibs and Kevin Ottens.
> 
> 
> Description
> -------
> 
> Show mtp devices if kio-mtp is installed, code is prepared for ptp devices as well.
> 
> Will add support once this patch gets accepted.
> 
> 
> Diffs
> -----
> 
>   kfile/kfileplacesitem.cpp 3ada0c3 
>   kfile/kfileplacesitem_p.h 3c6bd30 
>   kfile/kfileplacesmodel.cpp 82dee90 
> 
> Diff: http://git.reviewboard.kde.org/r/106657/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121001/4bf8e41d/attachment.htm>