Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107332/#review22227
-----------------------------------------------------------


This review has been submitted with commit d5c3c9822a38574162ea23463b8525a9f03beac2 by David Edmundson to branch KDE/4.10.

- Commit Hook


On Nov. 16, 2012, 2:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107332/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2012, 2:11 a.m.)
> 
> 
> Review request for kdelibs and Aurélien Gâteau.
> 
> 
> Description
> -------
> 
> Fix margin on KMessageWidget to match that used by a styled QFrame.
> 
> The rationale being that in almost every usage of KMessageWidget it's used above a sunken QFrame (kate, kmail, dolphin)
> currently the message widget is slight wider, which looks wrong.
> 
> Updated testing code to match the more common usage.
> 
> 
> Diffs
> -----
> 
>   kdeui/tests/kmessagewidgettest.cpp be517fce802a8594a6d4aae50f0d1c8955d3cbf2 
>   kdeui/widgets/kmessagewidget.cpp b87b3e49e9824c068bd1d85ac7ecb2de337fa86b 
> 
> Diff: http://git.reviewboard.kde.org/r/107332/diff/
> 
> 
> Testing
> -------
> 
> Screenshot shows the difference, look at left hand side of message widget lining up with the frame below.
> Also opened in Kate, KMail, Bluetooth KCM, ktp-accounts-kcm. All instances lined up.
> 
> 
> Screenshots
> -----------
> 
> Original KMessageWidget (left) and improved KMessageWidget (right)
>   http://git.reviewboard.kde.org/r/107332/s/833/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121120/ac8c5a5b/attachment.htm>