<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107332/">http://git.reviewboard.kde.org/r/107332/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d5c3c9822a38574162ea23463b8525a9f03beac2 by David Edmundson to branch KDE/4.10.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 16th, 2012, 2:11 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Aurélien Gâteau.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2012, 2:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix margin on KMessageWidget to match that used by a styled QFrame.
The rationale being that in almost every usage of KMessageWidget it's used above a sunken QFrame (kate, kmail, dolphin)
currently the message widget is slight wider, which looks wrong.
Updated testing code to match the more common usage.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Screenshot shows the difference, look at left hand side of message widget lining up with the frame below.
Also opened in Kate, KMail, Bluetooth KCM, ktp-accounts-kcm. All instances lined up.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/tests/kmessagewidgettest.cpp <span style="color: grey">(be517fce802a8594a6d4aae50f0d1c8955d3cbf2)</span></li>
<li>kdeui/widgets/kmessagewidget.cpp <span style="color: grey">(b87b3e49e9824c068bd1d85ac7ecb2de337fa86b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107332/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107332/s/833/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/15/kmessage-widget2_400x100.png" style="border: 1px black solid;" alt="Original KMessageWidget (left) and improved KMessageWidget (right)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>