Review Request: QtWebKit is needed but not required bei CMakeList.txt

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107386/#review22214
-----------------------------------------------------------


Strange location for the check, this sounds like something that should be next to kdewebkit, or even inside kdewebkit. This would be more modular (and I'm all for modularity, see kde frameworks 5 ;-)

Also, shouldn't this use macro_log_feature, like for all other mandatory dependencies?

- David Faure


On Nov. 19, 2012, 2:54 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107386/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2012, 2:54 p.m.)
> 
> 
> Review request for kdelibs, David Faure and Alexander Neundorf.
> 
> 
> Description
> -------
> 
> Some files, such as kdewebkit/kwebwallet.h, need some h-file from QtWebKit, but this is not yet required from CMakeLists.txt 
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 893f00e 
> 
> Diff: http://git.reviewboard.kde.org/r/107386/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121119/861089e1/attachment.htm>