<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107386/">http://git.reviewboard.kde.org/r/107386/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Strange location for the check, this sounds like something that should be next to kdewebkit, or even inside kdewebkit. This would be more modular (and I'm all for modularity, see kde frameworks 5 ;-)
Also, shouldn't this use macro_log_feature, like for all other mandatory dependencies?</pre>
<br />
<p>- David</p>
<br />
<p>On November 19th, 2012, 2:54 p.m., Guy Maurel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, David Faure and Alexander Neundorf.</div>
<div>By Guy Maurel.</div>
<p style="color: grey;"><i>Updated Nov. 19, 2012, 2:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some files, such as kdewebkit/kwebwallet.h, need some h-file from QtWebKit, but this is not yet required from CMakeLists.txt </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(893f00e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107386/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>