Review Request: remove an assert

Andras Mantia amantia at kde.org
Sat Nov 10 11:37:52 GMT 2012


On Tuesday, November 06, 2012 09:08:36 AM Jaime Torres Amate wrote:
> > On Nov. 6, 2012, 6:46 a.m., David Edmundson wrote:
> > > The responsibility of deleting d->rootDir seems to lie within KArchive.
> > > Therefore by setting the rootDir twice either implicitly or explicitly
> > > (which this assert is designed to avoid) you risk leaking the first
> > > KArchiveDirectory object.
> > > 
> > > I think you need something more involved than just removing the checks.
> 
> The problem comes from ktar.cpp, line 472 after finding a "." directory
> entry in a .tar file. For example, the kdevelop ruby templates at
> $KDE_INSTALL_DIR/share/apps/kdevappwizard/templates/kderubyapp.tar.bz2

The problem is in KTar and should be fixed there. The bug is reported already:
https://bugs.kde.org/show_bug.cgi?id=309463

FYI, the assert is not hit by final users "just" by those using developer build 
of kdelibs.

Andras





More information about the kde-core-devel mailing list