Review Request: parenthesis and not null checking
Jaime Torres Amate
jtamate at gmail.com
Mon Nov 5 15:13:07 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107213/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
place some parenthesis around ! operators, with less priority than ^ operators.
place some parenthesis around = inside conditions
check for n not being null before using it
simplify if (a==true) return true else return false;
Diffs
-----
khtml/khtml_caret.cpp 45fd90c
khtml/rendering/render_inline.cpp acfc1e4
khtml/rendering/render_object.cpp f37627c
solid/solid/backends/wmi/wmiopticaldisc.cpp c6e390f
Diff: http://git.reviewboard.kde.org/r/107213/diff/
Testing
-------
I've been using this code several weeks.
Thanks,
Jaime Torres Amate
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121105/c9ba8372/attachment.htm>
More information about the kde-core-devel
mailing list