Review Request: Remove additional directories from shortcuts scheme export path

David Faure faure at kde.org
Wed May 30 18:07:18 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104981/#review14281
-----------------------------------------------------------

Ship it!


I happened to have a look at that code while porting stuff in KDE Frameworks 5, and this fix looks very much correct.

- David Faure


On May 27, 2012, 7:17 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104981/
> -----------------------------------------------------------
> 
> (Updated May 27, 2012, 7:17 p.m.)
> 
> 
> Review request for kdelibs, Andreas Pakulat and Alexander Dymo.
> 
> 
> Description
> -------
> 
> The Configure Shortcuts dialog has an Action to export a scheme 
> (Details->More Actions->Export Scheme)
> 
> Using this action the user is asked for a export location and has to select a directory.
> Then the current scheme 'schemename' in application 'appname' is exported to a file 
> named appnameschemenameshortcuts.rc.
> 
> But this file is not saved in the selected directory as Joe User would expect, but in 
> shortcuts/share/apps/appname/ below the selected folder.
> 
> This patch removes the additional directories shortcuts/share/apps/appname/ from 
> the export path to make it easier for the user to find the scheme file and move/copy 
> it via command line (there is no GUI to import a scheme).
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kshortcutschemeseditor.cpp 34a485a 
> 
> Diff: http://git.reviewboard.kde.org/r/104981/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120530/09d7a331/attachment.htm>


More information about the kde-core-devel mailing list