Review Request: Do not restore previously empty location bar URL

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104982/
-----------------------------------------------------------

Review request for KDE Base Apps and David Faure.


Description
-------

The attached patch fixes the issue reported in the aforementioned bug report. Specifically, it stops Konqueror from restoring the location bar to the previous URL if 

a.) It was empty as in a newly created tab.
b.) The user typed in a new URL that cannot be handled by Konqueror. The URL was launched with another application.


This addresses bug 270723.
    http://bugs.kde.org/show_bug.cgi?id=270723


Diffs
-----

  konqueror/src/konqview.cpp bfeb20b 

Diff: http://git.reviewboard.kde.org/r/104982/diff/


Testing
-------

Tested the following three scenarios:

1.) Open a new tab in Konqueror and type-in a URL it cannot handle.
2.) Open a new tab, browse to any location, and then type-in a URL Konqueror cannot handle.
3.) Open a new tab, browse to any location, clear the location bar, and then type-in a URL Konqueror cannot handle.

Results with the patch:
1.) The typed in URL remains in the location bar.
2.) The previous URL is restored in the location bar.
3.) Same as #2.


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120518/0434cee7/attachment.htm>