Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103610/
-----------------------------------------------------------

(Updated May 19, 2012, 4:36 p.m.)


Review request for kdelibs and Thiago Macieira.


Changes
-------

Modified the patch to address the following additional issues:

Fixed very very long connection times when vising certain sites, e.g. "Apply Now" button at http://www.suse.com/company/careers/, by using KTcpSocket::SecureProtocols instead of KTcpSocket:TlsV1 as the default SSL protocol.
    
Improved the speed of SSL negotiation by caching and sharing the previous settings amongst ioslaves when those settings are not the default ones. That way any ioslave that connects to the same host afterwards does not have to perform the same expensive SSL negotiation process all over again.


Description
-------

The attached patch addresses the issue of SSL handshake failure in TcpSlaveBase due to lack of support for disabling SSL compression in Qt. As of 4.8, Qt supports this functionality so this patch implements support for activing that support in KTcpSocket and using it from KIO::TcpSlaveBase so that users will be able to browse SSL protected sites that do not support SSL compression.


This addresses bug 275524.
    http://bugs.kde.org/show_bug.cgi?id=275524


Diffs (updated)
-----

  kio/kio/tcpslavebase.h fea2c08 
  kio/kio/tcpslavebase.cpp d0f92b4 

Diff: http://git.reviewboard.kde.org/r/103610/diff/


Testing
-------

Visit the site listed in the bug report: 
https://tim.rz.rwth-aachen.de/mail-lifecycle/


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120519/6a34868c/attachment.htm>