Review Request: Enable css border rendering on styled select elements

Andrea Iacovitti aiacovitti at
Fri May 18 10:35:57 BST 2012

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


The patch enable rendering of css border for styled select elements (combobox+listview).
This is done by using KdeUiProxyStyle as already done by other widgets in khtml.
For styled combobox the drop down arrow is rendered by drawing PE_IndicatorArrowDown of the base style,
so it will look different depending on the system style being in use.

This addresses bugs 299934 and 300227.


  khtml/css/html4.css 9f4d17b 
  khtml/rendering/render_form.h 2be4df5 
  khtml/rendering/render_form.cpp b4cf136 



. khtml testregression -> no further test fails
. tested against different basestyle: oxygen, qtcurve, available qt styles (plastique, qcleanlooks ...)
. tested against Qt 4.7.4, Qt 4.8.1
. daily browsing


shoot of a bko page before/after the patch


Andrea Iacovitti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list